-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ptf docker with saithrift installed #54
Conversation
…docker-ptf. Don't wait until interfaces are active for syncd-rpc containers
@@ -44,5 +45,4 @@ COPY ptf_nn_agent.conf /etc/supervisor/conf.d/ptf_nn_agent.conf | |||
|
|||
ENTRYPOINT service rsyslog start \ | |||
&& service syncd start \ | |||
&& while [ "x$( ifconfig Ethernet12 | grep RUNNING )" = 'x' ] ; do sleep 1 ; done \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan This is not in this pull request. It is a commit aed2ab5 pushed by @pavel-shirshov.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the PR is not based on the latest master. better to generate PR based on latest master.
RUN tar xzf /deps/saithrift-0.9.tar.gz -C /usr/share/; \ | ||
cd usr/share/saithrift-0.9; \ | ||
python setup.py install; \ | ||
rm -rf /deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to put all these into docker-ptf since there are the same for different platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep them in an independent docker though the dockerfile itself is not platform-specific. As else we will introduce a dependency of saithrift package into docker-ptf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to limit the number of docker types we have to manage.
@@ -0,0 +1,33 @@ | |||
# ptf host interface @ switch front port name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to docker-ptf
@@ -0,0 +1,33 @@ | |||
# ptf host interface @ switch front port name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to docker-ptf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-generate this pr against the current master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-generate this pr against the current master
Commits on Aug 15, 2019 [sonic_sfp] Fix global name about sfp module is not defined (#53) 04014b6 Commits on Aug 20, 2019 [xcvrd] Fix crashing due to missing fields of some module types (#54) c011c73 Remove duplicated sonic_eeprom and create symlink (#55) 087593e Commits on Sep 10, 2019 [sfp_base] Raise exceptions (previously was incorrectly returning the… c21507e Added new API to interact with the platform components (#60) 33b037d Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
update multiDB changes in sonic-py-swsssdk, including: *[multi-DB] Part 4: add sonic-db-cli to replace redis-cli (#54) *[multi-DB] Part 3: Python API changes (#52) *remove SonicV2Connector which is not used any more (#53) This needs #3825 to be merged first. Otherwise when reloading minigraph/config will hit error. Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com
…ld infra changes. (sonic-net#54) * [sonic-yang-mgmt]: Move yang models to src/sonic-yang-models and build infra changes. 1.) Move yang models to src/sonic-yang-models. 2.) New build infra for src/sonic-yang-models. 3.) Change in build infra for src/sonic-yang-mgmt. 4.) Makefile changes to make sonic-yang-mgmt depend on sonic-yang-models. 5.) Test files changes. * [sonic-yang-mgmt/setup.py]: Find path of dependencies of os environment. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [sonic-yang-mgmt/setup.py]: Change Python tag from Py2 to Py. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [sonic-extension.yang]: Re-add sonic-extension file. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [sonic-slave-jessie/Dockerfile.j2]: Remove ijson from jessie. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [LICENSE]: Changing sonic-yang-mgmt LICENSE. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [sonic-yang-models/LICENSE]: Changing license to APACHE. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [rules/sonic-yang-mgmt-py2.mk]: Reverting back to PY2. Changes: -- Reverting back to PY2. -- Keeping package environment varible name to SONIC_YANG_MGMT_PY Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com * [sonic-yang-models/setup.py]: Address LGTM issues and rebasing. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
…c-net#54) From SFF-8436 regarding cable length fields: "A value of zero means that the Module does not support (this mode) or that the length information must be determined from the Module technology." It is possible that all cable length fields in eeprom are 0, and this would lead to xcvrd crashing due to fetching of this data. Fallback is added in this case.
lldpd depends on libsnmp, since we removed snmp from this job, we also need remove lldpd
* [multi-DB] Part 4: add sonic-db-cli to replace redis-cli * use SonicV2Connector instead and fix previous if condition typo * remove unused import * use_unix_socket_path set to False by default to avoid unnecessary failed * update Usage message and add example under -h * remove logging and update usage msg
[202012][sonic-linkmgrd]Submodule update 8507629 Jing Zhang Mon Apr 4 10:25:22 2022 -0700 Lower unsolicited MUX state change notification log level to WARNING #57 17d217d Longxiang Lyu Mon Mar 21 12:15:19 2022 +0800 Enhance clang format (#46) c72fa2a Jing Zhang Fri Apr 1 12:23:29 2022 -0700 Disable the feature that decreases link probe interval for measuring switch overhead #49 (#54) 256b01b Jing Zhang Thu Mar 31 16:20:00 2022 -0700 Update link prober metrics posting logics #50 #53 dfd48d0 Jing Zhang Wed Mar 23 16:27:45 2022 -0700 Decrease link probing interval after switchover to better determine the overhead of a toggle #43 (#48) sign-off: Jing Zhang zhangjing@microsoft.com
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (sonic-net#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (sonic-net#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (sonic-net#54) Signed-off-by: Ze Gan <ganze718@gmail.com>
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (sonic-net#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (sonic-net#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (sonic-net#54) Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
…c-utilities [submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically
…2d_syncd_failed [Platform][AS9716-32D]: Fix syncd init failed during system boot-up phase
No description provided.